New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship unminified js #2029
Ship unminified js #2029
Conversation
js is also moved to top-level dir so it will only be included in sdists, not installs. |
What's the status with the different types of download we offer? I seem to remember that we already have a 'complete' tarball including doc sources, and a smaller tarball so |
I think we just have one sdist, which no longer has the built docs, and would have this js. I don't think there are any tarballs with the docs other than downloading a snapshot of the ipython-doc repo. |
If we want it to only be in the repo, and in no installs, then we can remove it from the manifest. In that case, the release tag on GitHub would have it, but sdists would not. |
I think I'd go with that path (removing it from the manifest), and point packagers to the tag-tarball on Github. For people regularly creating virtualenvs, I'd like to keep the download from pypi as small as possible. |
@takluyver sounds good. For that matter, we could exclude the doc sources from the sdist, if we really wanted to keep it small. |
removed from manifest. |
I'd lean that way, although we should think about it a bit, because there'll always be that time you want to refer to the docs somewhere without wifi, like on a plane.
|
Let's consider what we do with docs separately... I've been thinking recently that, given the discussions we had at pydata indicating there will be no improvements to python docstrings forthcoming from python-dev ever, IPython should take the lead in offering documentation access to users. Solid, easy to find help with good search and relevant examples is the one area where Matlab/Mathematica literally mop the floor with the python tools. It's not even funny how utterly pathetic our solutions are compared to what those environments offer on this front. But I think we now have in IPython enough machinery (in particular in the notebook) to tackle that problem, and to start thinking about how to offer better interactive access to help. Ultimately I'd like to do so for all the various projects, but we should obviously start by testing any ideas on IPython itself, before we suggest other projects adopt this. |
Back to the topic of this PR, once we hear from @juliantaylor if it satisfies Debian's packaging policies in full, then I think we can merge. Thanks @minrk for taking care of this one! |
this should be enough to remove the need for repackaging (and the +dfsg) suffix. Thank you. I don't really want to bump the -docs to recommends, as a low bandwidth user I like my packages small and granular. |
and exclude it from MANIFEST, so it will not be in sdists, only available in the repo / via release tag.
Honestly, I don't know where the best place is to put it. It didn't seem right that it was in the static dir, which looked too much to me like actually used code, and was available to notebook clients. And yes, it is easy to exclude or include it from anything, no matter where we put it. Perhaps the most logical location is external/js, since these really are external dependencies (this PR now reflects this). @juliantaylor thanks for your patience, and all your packaging help. Sorry for the bother. |
+1 for external, just so it doesn't clutter the top level. Can you make that change before we merge it then? |
already did :) |
I clobbered the original commit, so it looks like I did it yesterday (git time machines ftw!) |
Ship unminified js for easier packaging. We now conform to the Debian packaging guidelines regarding the presence of binary blobs (the minified JS sources). Includes unminified single-file versions of prettify, jQuery-1.7.1, and jquery/jquery-ui@ba8f147. These files are totally unused by us, as we use the minified code, but allow packagers to validate/reminify/etc according to their own policies. Closes #1265.
sneaky; not fair to win an email race with a time machine ;) |
Ship unminified js for easier packaging. We now conform to the Debian packaging guidelines regarding the presence of binary blobs (the minified JS sources). Includes unminified single-file versions of prettify, jQuery-1.7.1, and jquery/jquery-ui@ba8f147. These files are totally unused by us, as we use the minified code, but allow packagers to validate/reminify/etc according to their own policies. Closes ipython#1265.
For packaging.
closes #1265
Includes unminified single-file versions of prettify, jQuery-1.7.1, and jquery/jquery-ui@ba8f147
These files are totally unused.