Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for a few places we should be using DEFAULT_ENCODING #2032

Closed
minrk opened this issue Jun 24, 2012 · 2 comments
Closed

check for a few places we should be using DEFAULT_ENCODING #2032

minrk opened this issue Jun 24, 2012 · 2 comments
Labels
unicode
Milestone
2.0

Comments

@minrk
Copy link
Member

minrk commented Jun 24, 2012

There are a few places in the code where we should probably be using DEFAULT_ENCODING, but are using an explicit, different fallback (e.g. writing to readline hist).

As mentioned in #2027, we don't want to make any potentially sensitive changes like this so close to releasing 0.13.
@minrk minrk mentioned this issue Jun 24, 2012
Merged
minrk added a commit that referenced this issue Jun 24, 2012
@minrk
Merge pull request #2027 from minrk/stdin_enc
7bab692 
match stdin encoding in frontend readline test

The real fix is probably the reverse, but should not be changed this close to release (see #2032).

closes #2023
@minrk
Copy link
Member Author

minrk commented Jan 29, 2014

@takluyver do you think we are doing a reasonable job of selecting encodings at this point?

@takluyver
Copy link
Member

Yes, I think so. If there are still problems, we can file specific issues for them as they come up - there's no point in keeping this open.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#2027 from minrk/stdin_enc
a6576c1 
match stdin encoding in frontend readline test

The real fix is probably the reverse, but should not be changed this close to release (see ipython#2032).

closes ipython#2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unicode
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@minrk @takluyver