Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emacs completion bugfix #204

Closed
wants to merge 3 commits into from
Closed

Conversation

wilsaj
Copy link
Contributor

@wilsaj wilsaj commented Nov 22, 2010

Tab completion in ipython.el seems to have stopped working because it calls completer.IPCompleter.all_completions(), which is broken. IPCompleter.complete() now returns a list of all possible completions so it can be used instead of all_completions().

@limist
Copy link

limist commented Jan 16, 2011

This works for me; I modified my .emacs to have,

(setq ipython-completion-command-string "print(';'.join(get_ipython().Completer.complete('%s')[1])) #PYTHON-MODE SILENT\n")

@minrk
Copy link
Member

minrk commented Feb 14, 2011

This removes all_completions from Completer, but it is also used in IPython.core.debugger.Pdb. That should presumably be changed as well.

just make it a very thin wrapper around the
IPython.completer.Completer.complete method so that pydb will still
work correctly.
IPython.completer.Completer.all_completions docstring
@wilsaj
Copy link
Contributor Author

wilsaj commented Feb 16, 2011

I'm sorry that I missed that.

It looks like there isn't a clean fix for the IPython.core.debugger.Pdb thing, since that is bound up in the interface to pydb. The debugger code replaces the completer.all_completions with pydb's all_completions method and emacs will need to call that one without the indexing business.

Anyway, I pushed a new commit that just makes all_completions a very thin wrapper around the complete method; that should work for everyone.

@wilsaj
Copy link
Contributor Author

wilsaj commented Mar 24, 2011

Fix emacs tab-completion with simpler implementation.

Add pydb to the list of beneficiaries in the
IPython.completer.Completer.all_completions docstring

Closed by ef40b1c.

@fperez fperez closed this Mar 24, 2011
markvoorhies pushed a commit to markvoorhies/ipython that referenced this pull request Apr 21, 2011
Add pydb to the list of beneficiaries in the
IPython.completer.Completer.all_completions docstring

Closes ipythongh-204.
@K0stIa
Copy link

K0stIa commented Mar 19, 2012

Hi all.
I'm using IPython in my emacs24 and auto-completion desn't work with this fix (setq ipython-completion-command-string "print(';'.join(get_ipython().Completer.complete('%s')[1])) #PYTHON-MODE SILENT\n")

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Add pydb to the list of beneficiaries in the
IPython.completer.Completer.all_completions docstring

Closes ipythongh-204.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants