Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook "Make a Copy..." keeps opening duplicates in the same tab #2120

Closed
ghost opened this issue Jul 11, 2012 · 3 comments · Fixed by #2128
Closed

Notebook "Make a Copy..." keeps opening duplicates in the same tab #2120

ghost opened this issue Jul 11, 2012 · 3 comments · Fixed by #2128
Milestone
1.0

Comments

@ghost
Copy link

ghost commented Jul 11, 2012

The first time I click on "Make a Copy..." (say in tab 1 of my browser) it opens a duplicate in a new tab (say tab 2). But when I click "Make a Copy..." in tab 2, another copy is made in the same tab (tab 2). If I click on "Make a Copy..." again in tab 1, I get yet another new duplicate in tab 2.

I clone notebooks a lot and this gets confusing quickly (the expected/preferred behaviour for me is that I always get a brand new tab). I'm not sure whether this can be fixed, or is due to the browser?

Reproduced on Win 7, Chrome 20.0.1132.47 beta-m, Firefox 13.0.1.

Edit: I realize one can always right click to enforce a new tab, but that's easy to forget since it looks like an ordinary application menu, and it doesn't work very well (opens the same notebook, not a copy, in tab 3, from which you can make a copy into tab 4).
@Carreau Carreau mentioned this issue Jul 12, 2012
Merged
@Carreau
Copy link
Member

Carreau commented Jul 12, 2012

Try #2128, it seem to works on Chrome OS X, but I'm not sure if sometime it is not a browser safety feature to avoid Forkbomb.

@ghost
Copy link
Author

ghost commented Jul 12, 2012

Yep, always opening in a new tab on both Chrome & FF on Win 7 now. Fantastic, thanks!

@Carreau
Copy link
Member

Carreau commented Jul 13, 2012

Closing as autoclose failed.

@Carreau Carreau closed this as completed Jul 13, 2012
Carreau added a commit to Carreau/ipython that referenced this issue Jul 13, 2012
@Carreau
open notebook copy in different tabs
f7db56b 
returning false to allow modifier+click,
otherwise open 2 tabs at once.

fixes ipython#2120

backported to 0.13.1 from PR ipython#2128
minrk added a commit that referenced this issue Jul 21, 2012
@minrk
Backport PR #2128: open notebook copy in different tabs
deed657 
use time since epoch to avoid reusing the same tab
fixes #2120
as long as one dos not open more that one tab per second.
@minrk minrk added this to the 1.0 milestone Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

open notebook copy in different tabs Carreau/ipython
2 participants
@minrk @Carreau