Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small issue: wrong printout #2244

Closed
wkerzendorf opened this issue Aug 3, 2012 · 2 comments
Closed

small issue: wrong printout #2244

wkerzendorf opened this issue Aug 3, 2012 · 2 comments
Labels
bug documentation
Milestone
1.0

Comments

@wkerzendorf
Copy link

The ipython notebook proclaims:
"WARNING: the notebook server is listening on all IP addresses but not using any encryption or authentication"

although it is using authentication (but it doesn't use encryption).

That should be changed to:
"WARNING: the notebook server is listening on all IP addresses but is not using BOTH encryption and authentication"
@bfroehle
Copy link
Contributor

bfroehle commented Aug 3, 2012

Perhaps this should be split into two error messages?
WARNING: ... no authentication
WARNING: ... not encrypted, ... blah blah insecure.

@wkerzendorf
Copy link
Author

That works as well (is even better, but is slightly more work). It really is a small thing, but I thought I mention it.

dkua pushed a commit to dkua/ipython that referenced this issue Nov 13, 2012
Refactored warning printout as per Issue ipython#2244
cadbfa5
dkua pushed a commit to dkua/ipython that referenced this issue Nov 13, 2012
Refactored warning printout as per Issue ipython#2244
77728fb
@fperez fperez mentioned this issue Nov 13, 2012
Merged
minrk added a commit that referenced this issue Mar 5, 2013
@minrk
Backport PR #2574: Fix #2244
f5f55a0 
Reformatted the warning message as per the issue and changed some of the original logic to be more readable as advised by Fernando.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Refactored warning printout as per Issue ipython#2244
8687376
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@Carreau
Merge pull request ipython#2574 from dkua/Fix#2244
115b3a2 
Reformatted the warning message of notebook server starting.

Public IP without SSL should prompt a warning.
Public IP in read-write mode and no password, also a warning.

Fix ipython#2244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@bfroehle @Carreau @wkerzendorf