Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook: "Down_Arrow" on last line of cell should move to end of line #2275

Closed
bfroehle opened this issue Aug 9, 2012 · 4 comments · Fixed by #2277
Closed

notebook: "Down_Arrow" on last line of cell should move to end of line #2275

bfroehle opened this issue Aug 9, 2012 · 4 comments · Fixed by #2277
Labels
Milestone

Comments

@bfroehle
Copy link
Contributor

bfroehle commented Aug 9, 2012

In a notebook cell, while the cursor is somewhere in the middle of the final line of a cell, hitting currently moves to the next cell. I would have expected it to move to the end of the line, or the next cell if it already at the end of the line.

In addition, I would also expect ⇧ Shift- to select from the current location to the end of the line.

Edit: I've updated this to reflect @minrk's comments.

@minrk
Copy link
Member

minrk commented Aug 9, 2012

This isn't quite accurate - when the cursor is in the bottom of the cell and you press down, the cursor moves to the next cell.

I have the same expectation, but any fix should include down from the end of the last line behaving the same as down does now.

@ellisonbg
Copy link
Member

@minrk: not sure I am following you. When I tested this PR I saw the
following:

  • If you press DOWN while on the last row, you first go to the EOL.
  • If you press DOWN again, you go to the next cell.

Do you see something different?

On Thu, Aug 9, 2012 at 4:02 PM, Min RK notifications@github.com wrote:

This isn't quite accurate - when the cursor is in the bottom of the cell
and you press down, the cursor moves to the next cell.

I have the same expectation, but any fix should include down from the end
of the last line behaving the same as down does now.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2275#issuecomment-7629675.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member

minrk commented Aug 9, 2012

I haven't looked at the PR, only read this Issue, which had an inaccurate description of what currently happens. If the PR does behave like that, then that's great!

@bfroehle
Copy link
Contributor Author

Closed by the merged pull request #2277.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants