Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small change needed to rmagic extension. #2615

Closed
milkypostman opened this issue Nov 24, 2012 · 2 comments
Closed

Small change needed to rmagic extension. #2615

milkypostman opened this issue Nov 24, 2012 · 2 comments
Milestone
1.0

Comments

@milkypostman
Copy link

https://github.com/ipython/ipython/blob/master/IPython/extensions/rmagic.py#L326

When parsing arguments for %R the rmagic extension requires the units argument (-u / --units) to be an integer, but the parameter is supposed to be one of ["px", "in", "cm", "mm"] and thus it is impossible to pass this argument.
@takluyver
Copy link
Member

I think you're right. Do you want to submit a pull request? Just click 'edit this file' on rmagic.py. It will also need a little tweak around line 510, because we'll need to pass that argument with quotation marks around it.

@milkypostman milkypostman mentioned this issue Nov 25, 2012
Merged
@takluyver
Copy link
Member

Closed by PR #2617.

@minrk minrk added this to the 1.0 milestone Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@milkypostman @minrk @takluyver