Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyZMQ >= 2.0.10 #268

Closed
wants to merge 2 commits into from
Closed

PyZMQ >= 2.0.10 #268

wants to merge 2 commits into from

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 12, 2011

Cleaner error if pyzmq is missing or pre-2.0.10.

On import of IPython.zmq, an ImportError with a meaningful message will be raised if pyzmq is found to be older than the current dependency of 2.0.10.

This could be changed to 2.0.10.1, which fixes a memory leak in 2.0.10 - thoughts?

@fperez
Copy link
Member

fperez commented Feb 12, 2011

Hey,

I installed from the v2.0.10-1 tag in the pyzmq repo, but I get

In [1]: import zmq

In [2]: zmq.__version__
Out[2]: '2.0dev'

So the check in this pull request would preclude this from working... Is it a problem with that tag in pyzmq?

@minrk
Copy link
Member Author

minrk commented Feb 12, 2011

There isn't a v2.0.10-1 tag... Some things got a little confused when we briefly had 2.0.10-1, but changed it to 2.0.10.1. There was still a dangling (not tagged, no 'v') 2.0.10-1 branch, so I just removed that, and replaced it with a proper 2.0.10.1 branch pointing to the v2.0.10.1 tagged commit.

Can you checkout [v]2.0.10.1? ack reveals no instances of '2.0dev' in that revision that I can find.

'2.0dev' is the version string we are using for bugfixes in 2.0.x (aka maint in zeromq). '2.0dev' > '2.0.10', so assuming 2.0.x is up-to-date, then the check still evaluates correctly, because 2.0.x is indeed newer than 2.0.10.

@fperez
Copy link
Member

fperez commented Feb 12, 2011

OK, sounds good. Indeed, used that 2.0.10-1 branch.

Go ahead with the merge and I'm OK with making -1 the minimum required one: anyone running this stuff is building from source for now, and we might as well be sure they're running a good version... Go for the merge, thanks!

@minrk
Copy link
Member Author

minrk commented Feb 12, 2011

require pyzmq >= 2.0.10.1

closed by 729f8ad

@fperez
Copy link
Member

fperez commented Feb 12, 2011

Great, thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants