bashism in sshx.sh #274

Closed
juliantaylor opened this Issue Feb 16, 2011 · 2 comments

2 participants

@juliantaylor

the default sshx.sh in 0.10.1 and lower uses a bash feature in a shell which may not support it:

#!/bin/sh
"$@" &> /dev/null &
echo $!

the non-posix redirection &> may not be supported when /bin/sh does not support it, e.g. dash.
a possible fix is:
"$@" > /dev/null 2>&1 &

@fperez
IPython member

Thanks for the report and fix! Committed locally, this will close when I push.

@fperez
IPython member

Remove bash-ism and use standard posix redirect in sshx.sh script.

Closed by a63739a, thanks to github user juliantaylor for the fix!

@jedludlow jedludlow pushed a commit that referenced this issue Dec 19, 2012
@fperez fperez Remove bash-ism and use standard posix redirect in sshx.sh script.
Closes gh-274, thanks to github user juliantaylor for the fix!
a63739a
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment