Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KernelManager and KernelClient should be two separate objects #2803

Closed
minrk opened this issue Jan 18, 2013 · 1 comment
Closed

KernelManager and KernelClient should be two separate objects #2803

minrk opened this issue Jan 18, 2013 · 1 comment
Labels
Milestone

Comments

@minrk
Copy link
Member

minrk commented Jan 18, 2013

Managing a kernel process and communicating with a kernel are two separate tasks.
The KernelManager conflates both of these, and the code gets weird due to the fact that KernelManagers do not always have the right to start/stop/restart the kernel (e.g. --existing cases).

For instance, in the notebook code, only the management parts of the kernel are used, and the communication (channels) should be done differently, in a tornado-appropriate manner.

The shutdown/restart logic is the main place where these two roles collide, because a clean shutdown request goes via the shell channel. One way in which this could be addressed would be to add the Control channel already used in IPython.parallel. That should enable a clean split of the KernelManager from the KernelClient.

Further, KernelClients should also be connected to the KernelManager, which would enable remote signaling/interrupts via the control channel, eliminating the long annoying "Kernel process is either remote or unspecified. Cannot interrupt." messages.

@minrk
Copy link
Member Author

minrk commented Jul 4, 2013

fixed by IPEP 13

@minrk minrk closed this as completed Jul 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant