Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up arrow key history search gets stuck in QTConsole #2943

Closed
joonro opened this issue Feb 16, 2013 · 8 comments · Fixed by #2946
Closed

Up arrow key history search gets stuck in QTConsole #2943

joonro opened this issue Feb 16, 2013 · 8 comments · Fixed by #2946
Labels
bug qtconsole
Milestone
1.0

Comments

@joonro
Copy link
Contributor

joonro commented Feb 16, 2013

With the ipython installed with with commit 50a5838, going through history with up arrow key in qtconsole works without any problem. But in current commit 48b63c1, in qtconsole, it gets "stuck" after several items - pressing up arrow key does not do anything. It seems to be happening when the currently showing history is longer than the qtconsole width.

Since there are more than 120 commits in between, I haven't tried to identify what was the commit which caused this.

Also, in terminal this does not happen.
@minrk
Copy link
Member

minrk commented Feb 16, 2013

Can you provide specific reproduction steps? The relevant change is almost certainly #2819.

Also, in terminal this does not happen.

Not surprising, since there isn't a line of code in common wrt the input history (terminal is 100% readline, qtconsole doesn't involve readline).

@minrk minrk mentioned this issue Feb 16, 2013
Merged
@minrk
Copy link
Member

minrk commented Feb 16, 2013

I think I figured it out. Try #2946.

@joonro
Copy link
Contributor Author

joonro commented Feb 17, 2013

I just replaced the file from your commit but now actually up arrow only go up one history and then I'm stuck.

@joonro
Copy link
Contributor Author

joonro commented Feb 17, 2013

I'm sorry, actually it might have caused by some left over files from previous installation of ipython. Let me remove them and try again.

@joonro
Copy link
Contributor Author

joonro commented Feb 17, 2013

Again - the new commit only gives one previous history.

Also when I delete everything and reinstall ipython from current master 48b63c1, the up arrow history did work as expected. I am afraid that it was caused by my mistake in the first place. I'm very sorry for wasting your time.

@minrk
Copy link
Member

minrk commented Feb 17, 2013

I grabbed the wrong cursor object, try #2946 again.

@joonro
Copy link
Contributor Author

joonro commented Feb 17, 2013

It is working well now :)

@minrk minrk closed this as completed in 427f551 Feb 20, 2013
@joonro
Copy link
Contributor Author

joonro commented Feb 20, 2013

@minrk Thanks a lot for this.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
fix qtconsole history logic for end-of-line
7052404 
EndOfLine may or may not mean the end of a full line when the line is longer than the window.
This commit uses the same logic to check as the actual move, so it should be consistent.

closes ipython#2943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug qtconsole
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

fix qtconsole history logic for end-of-line minrk/ipython
2 participants
@minrk @joonro