Magic local scope #295
Merged
Magic local scope #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1734,6 +1735,10 @@ class InteractiveShell(Configurable, Magic): | |||
| valid Python code you can type at the interpreter, including loops and | |||
| compound statements. | |||
| """ | |||
| # Save the scope of the call so magic functions like %time can | |||
| # evaluate expressions in it. | |||
| self._magic_locals = inspect.stack()[1][0].f_locals | |||
There was a problem hiding this comment.
Look at utils.frame, and add a decorator so we're only doing this if the magic command needs it.
|
Reviewed during sage days 29 sprint, ready for merge after minor fixes discussed there. Thanks! |
|
OK, I've revised it as we agreed. I've also rebased on master, so that I could test it easily. |
|
I've merged and pushed it with Thanks for the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is how we want to do this, or if we want to do it at all, but here it is for consideration.
Sage bug 10933 (http://trac.sagemath.org/sage_trac/ticket/10933) highlighted that we couldn't use the %time magic command inside a function. This captures the stack frame which called magic_time, and uses its local namespace to evaluate or execute the code passed to %time. It could also be used by other magic functions, although so far I've only added it to magic_time.