Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPython.notebook.dirty flag is not set when a cell has unsaved changes #3001

Closed
liyanage opened this issue Mar 5, 2013 · 2 comments
Closed

IPython.notebook.dirty flag is not set when a cell has unsaved changes #3001

liyanage opened this issue Mar 5, 2013 · 2 comments
Labels
bug notebook
Milestone
1.0

Comments

@liyanage
Copy link

liyanage commented Mar 5, 2013

I was editing a cell in a notebook without executing it. Then I queried the IPython.notebook.dirty flag in JS, and it was set to false. Only after I executed the cell did the flag switch to true.

This was with 0.13.1.
@ellisonbg
Copy link
Member

@minrk and I talked about this issue last night and concluded that we are going to make dirty an event that is emitted (among other times) whenever a CodeMirror gets a keyboard event. There will be false positives, but that is OK.

@minrk
Copy link
Member

minrk commented Jun 19, 2013

closed by #3371

@minrk minrk closed this as completed Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug notebook
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@ellisonbg @liyanage @minrk