[IPython 0.13.1] The check of PyQt version is wrong

[marco-buttu]

In IPython/external/qt.py, at line 43 and 55 there are the checks QtCore.PYQT_VERSION_STR < '4.7'. This is wrong:

Python 3.3.0 (default, Sep 29 2012, 17:14:58)
[GCC 4.7.2] on linux
Type "help", "copyright", "credits" or "license" for more information.

from PyQt4 import QtCore
QtCore.PYQT_VERSION_STR
'4.10'
QtCore.PYQT_VERSION_STR < '4.7'
True

Due to this bug I have an ImportError running ipython qtconsole:

ImportError: Cannot import PySide >= 1.0.3 or PyQt4 >= 4.7

[takluyver]

No, that wouldn't work either, because '4.6' > '4.07'.

It's already fixed in master, in any case.

[juliantaylor]

the fix should be backported to 0.13.2 else qtconsole won't run on newer distributions and it also breaks dependencies like spyder

[takluyver]

Ok, that makes sense. @minrk, what's the syntax to backport a commit?

[minrk]

should be python tools/backport_pr.py 0.13.x 2831

[minrk]

backport applied

[juliantaylor]

IPython.utils.version was forgotten in the backport

[minrk]

@juliantaylor thanks - I don't know how that happened, but it's fixed now.

[thebne]

Hotfix:

Replace
if QtCore.PYQT_VERSION_STR < '4.7':
with
if not all(map(lambda x: int(x[0]) >= int(x[1]), zip(QtCore.PYQT_VERSION_STR.split("."), '4.7'.split(".")))):