Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting errors from _repr_<type>_ methods #3026

Closed
lgautier opened this issue Mar 16, 2013 · 4 comments
Closed

Reporting errors from _repr_<type>_ methods #3026

lgautier opened this issue Mar 16, 2013 · 4 comments
Labels
Milestone

Comments

@lgautier
Copy link
Contributor

Hi,

Reporting errors from methods such as _repr_png(), _repr_html(), etc... would be extremely helpful.

Currently the error are silently ignored:

  • a user is not informed that something unexpected happened
  • a user is unable to report information about what went wrong

L.

@minrk
Copy link
Member

minrk commented Mar 17, 2013

it probably shouldn't raise, but a warning would definitely be better than silence.

@lgautier
Copy link
Contributor Author

I am guessing that that rationale for not raising is that the error is coming from the code the user did not explicit called, but a warning would already be a way to report that something is happening.

I'd argue that there should still be a way to raise an exception (even if only for development / debugging - this can be a debug switch somewhere).

@ellisonbg
Copy link
Member

@mink do you consider this fixed by your recent formatter work?

@minrk
Copy link
Member

minrk commented Jan 26, 2014

Yes, I didn't remember there being an open issue. Definitely fixed now.

@minrk minrk closed this as completed Jan 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants