Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Unicode Command-Line options #310

Closed
wants to merge 1 commit into from
Closed

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 25, 2011

This fixes a couple of unicode-related bugs from the command-line

Of particular note is that (in config/loader.py) argparse.parse_args will now always get a list of unicode objects, and never strs.

There is also a fix in InteractiveShell._safe_exec_file, where execfile (at least in 2.6.1) does not encode with the filesystemencoding, but rather the defaultencoding, so a unicode string will raise a UnicodeEncodeError.

Things that should now work that did not before:

ipython -p épsiløn
ipython ømqtést.py

@takluyver
Copy link
Member

Looks good to me. Specifying ipython -p test€ works in Linux with this.

@fperez
Copy link
Member

fperez commented Mar 25, 2011

Merge away, great!

@minrk
Copy link
Member Author

minrk commented Mar 25, 2011

Merge unicode-command-line fixes

closed by 14b9125

@minrk minrk closed this Mar 25, 2011
markvoorhies pushed a commit to markvoorhies/ipython that referenced this pull request Apr 21, 2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants