Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qtconsole exit #311

Closed
wants to merge 1 commit into from
Closed

Qtconsole exit #311

wants to merge 1 commit into from

Conversation

takluyver
Copy link
Member

Typing 'exit' at the Qt console had stopped working, although 'Exit' still worked. The prefilter system wasn't picking 'exit' up as an automagic, because of the presence of the builtin 'exit' function, which is removed before user code runs.

This does the prefiltering inside our builtin_trap context manager, so it doesn't see the exit builtin, and detects it as an automagic instead.

@fperez
Copy link
Member

fperez commented Mar 25, 2011

Thanks a lot! I rebased it on top of Robert's to avoid an unnecessary merge handle in the DAG, but content is unchanged. Commited as 67effcc.

@fperez fperez closed this Mar 25, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants