Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tornado 3.0 #3120

Closed
Carreau opened this issue Apr 1, 2013 · 5 comments
Closed

Tornado 3.0 #3120

Carreau opened this issue Apr 1, 2013 · 5 comments
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented Apr 1, 2013

Apparently tornado 3.0 has been released.
everything seem to work fine, but we should keep in mind
the new and removed stuff if we have issues.

@minrk
Copy link
Member

minrk commented Apr 1, 2013

I think the main issue we have in IPython is some logging messages being lost, but quite a few APIs have changed. I will be working on updating PyZMQ compatibility this week.

@Carreau
Copy link
Member Author

Carreau commented Apr 1, 2013

Can't set cookie with websocket:

Traceback (most recent call last):
  File "/Users/bussonniermatthias/ipython/IPython/frontend/html/notebook/handlers.py", line 492, in _inject_cookie_message
    bsession, msg = msg.split(':', 1)
ValueError: need more than 1 value to unpack

and

ERROR:tornado.application:Uncaught exception in /kernels/1e337c96-8e9e-4dc3-9c86-51d018724c05/iopub
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/tornado/websocket.py", line 281, in wrapper
    return callback(*args, **kwargs)
  File "/Users/bussonniermatthias/ipython/IPython/frontend/html/notebook/handlers.py", line 525, in on_first_message
    super(ZMQChannelHandler, self).on_first_message(msg)
  File "/Users/bussonniermatthias/ipython/IPython/frontend/html/notebook/handlers.py", line 504, in on_first_message
    if self.get_current_user() is None:
  File "/Users/bussonniermatthias/ipython/IPython/frontend/html/notebook/handlers.py", line 160, in get_current_user
    self.clear_login_cookie()
  File "/Users/bussonniermatthias/ipython/IPython/frontend/html/notebook/handlers.py", line 151, in clear_login_cookie
    self.clear_cookie(self.cookie_name)
  File "/usr/local/lib/python2.7/site-packages/tornado/web.py", line 427, in clear_cookie
    domain=domain)
  File "/usr/local/lib/python2.7/site-packages/tornado/websocket.py", line 246, in _not_supported
    raise Exception("Method not supported for Web Sockets")
Exception: Method not supported for Web Sockets

@minrk
Copy link
Member

minrk commented Apr 2, 2013

I presume you are using my stdin branch - this isn't an issue on master, and I've now fixed it in that branch as well.

@Carreau
Copy link
Member Author

Carreau commented Apr 3, 2013

I presume you are using my stdin branch - this isn't an issue on master, and I've now fixed it in that branch as well.

That's possible, I was demoing, don't remember the exact branch.

@minrk
Copy link
Member

minrk commented Jun 19, 2013

I (and presumably others) have been living on tornado 3.0 for some time, I think we can close this.

@minrk minrk closed this as completed Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants