Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NB should use normalize.css? was #3049 #3121

Closed
ghost opened this issue Apr 1, 2013 · 2 comments
Closed

NB should use normalize.css? was #3049 #3121

ghost opened this issue Apr 1, 2013 · 2 comments
Milestone

Comments

@ghost
Copy link

ghost commented Apr 1, 2013

After #3049 was fixed a little while ago It occured to me there might be
something more basic at play. I went back and modified the notebook
to load normalize.css before loading the IPython css (this is one package, there are others)
before and the issuewent away, without having to tack on styling to the notebook
classes themselves.

In retrospect this is probably a more correct solution, and conceivably
might shoot down similar issues in the future.

@ghost
Copy link
Author

ghost commented Apr 1, 2013

Oh, I see I fell victim to my browser's cache, normalize.css doesn't actually fix #3049.
Still, best practice you might consider using.
It's bundled with bootstrap btw, which I understand you're planning to move over to.

@Carreau
Copy link
Member

Carreau commented Apr 1, 2013

Yes, we are already moving to bootstrap and most of normalise should already be included.
Moving totally to bootstart we not happen soon I think, there a too many things to do, and not enought time to do everything.

as normalise is part of bootstrap and included in style.min.css I'll close. Thanks.

@Carreau Carreau closed this as completed Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant