Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtconsole: ValueError('close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr',) #3244

Closed
unpingco opened this issue Apr 30, 2013 · 5 comments · Fixed by #4031
Assignees
Labels
Milestone

Comments

@unpingco
Copy link

Line 308 in IPython/kernel/connect.py should be changed to

    return Popen([sys.executable, '-c', cmd, '--existing', cf] + argv,
    stdout=PIPE, stderr=PIPE, close_fds=sys.platform != "win32",

to account for this ValueError on windows.

@ghost ghost assigned minrk May 2, 2013
minrk added a commit to minrk/ipython that referenced this issue May 2, 2013
Because Windows can't deal with it

closes ipython#3244
@minrk
Copy link
Member

minrk commented Jul 4, 2013

closed by 14b007d

@minrk minrk closed this as completed Jul 4, 2013
@ghost
Copy link

ghost commented Aug 13, 2013

Hi,
I've just uploaded my IPython to version 1.0.0 and I got exactly this error trying to launch the qtconsole.
I've also fixed the problem manually changing IPython/kernel/connect.py file as in 14b007d.

@minrk
Copy link
Member

minrk commented Aug 13, 2013

@aezio what is sys.platform for you?

@ghost
Copy link

ghost commented Aug 14, 2013

'win32'
I've downloaded the executable file (py2.7 32 bit), maybe this fix has not been implemented in this build

minrk added a commit to minrk/ipython that referenced this issue Aug 14, 2013
straggler missed in 14b007d

closes ipython#3244 (again)
@minrk
Copy link
Member

minrk commented Aug 14, 2013

Gotcha - fix wasn't applied everywhere. Should be fixed by #4031.

minrk added a commit that referenced this issue Aug 16, 2013
straggler missed in 14b007d

closes #3244 (again)
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
straggler missed in 14b007d

closes ipython#3244 (again)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants