Tweak config loader for PyPy compatibility. #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go for it, this looks harmless enough. And since Brian will be reworking the config stuff over the next few days, might as well have it pypy-ok so those guys can cleanly track our work and alert us of any incompatibilities. Thanks, and also to @antocuni! @ellisonbg, just a heads-up that I think this is good to go as-is. Remember to update off master for this small change any config work you might have; shouldn't cause any problems (famous last words :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antonio Cuni (user antocuni) has tested IPython on a trunk version of PyPy. Apparently this is the only change needed to get it working. See issue #327 for discussion of the patch.
closes gh-327