Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt version check broken #3327

Closed
sprevrha opened this issue May 16, 2013 · 5 comments
Closed

Qt version check broken #3327

sprevrha opened this issue May 16, 2013 · 5 comments
Milestone

Comments

@sprevrha
Copy link

Raises error for Qt 4.10.1, even though that version should be compatible.
Problem is the lexical compare in external/qt.py @ L39 and L53 as indeed '4.7' > '4.10.1'.
Proposed solution: Convert version strings and compare by int

@takluyver
Copy link
Member

Thanks, but we've fixed it some time ago (#2831), and the fix is already in the latest release.

@sprevrha
Copy link
Author

True for master and 0.13 branch. Do you want to merge the fix into the 0.12
branch?
Sven

On Thu, May 16, 2013 at 2:32 PM, Thomas Kluyver notifications@github.comwrote:

Thanks, but we've fixed it some time ago (#2831#2831),
and the fix is already in the latest release.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3327#issuecomment-17998144
.

Sven

@Carreau
Copy link
Member

Carreau commented May 16, 2013

We don't have the manpower to backport everything to all version. Even if people issue PR that fixes the things, there is all the packaging behind and distribution.

Also, 0.13 has been stable for almost a year and has already had 2 bugfix releases. And we try to push people away from 0.12 because it has notebooks issues.

So I'm sorry, but IMHO that would be a no to backport to 0.12.

@sprevrha
Copy link
Author

No worries. I'll upgrade, and thanks for the reply! Thanks for all the
great work!
Sven
Am 16.05.2013 17:40 schrieb "Matthias Bussonnier" <notifications@github.com

:

We don't have the manpower to backport everything to all version. Even if
people issue PR that fixes the things, there is all the packaging behind
and distribution.

Also, 0.13 has been stable for almost a year and has already had 2 bugfix
releases. And we try to push people away from 0.12 because it has notebooks
issues.

So I'm sorry, but IMHO that would be a no to backport to 0.12.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3327#issuecomment-18009234
.

@takluyver
Copy link
Member

To reinforce what Matthias said: we only support one series at a time. So as soon as we released 0.13, backports to 0.12 stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants