Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Sphinx extensions #3352

Closed
mdboom opened this issue May 23, 2013 · 2 comments · Fixed by #3558
Closed

Install Sphinx extensions #3352

mdboom opened this issue May 23, 2013 · 2 comments · Fixed by #3558
Milestone

Comments

@mdboom
Copy link
Contributor

mdboom commented May 23, 2013

For what seems like a long time now, but matplotlib and IPython have both included ipython_console_highlighting.py and ipython_directive.py. (I think I wrote the former and John Hunter wrote the latter, originally).

Over time, these extensions have diverged. I think the IPython ones are better maintained as they actually track changes to IPython etc., and logically, I think these belong in IPython and not in matplotlib.

Unfortunately for third-party users of these packages, IPython does not install the sphinx extensions, but merely keeps them in the source tree. This has encouraged a lot of people to rely on the copies in matplotlib (which are installed). Any chance IPython could install them, too, then we could properly deprecate the copies in matplotlib?

@minrk
Copy link
Member

minrk commented May 23, 2013

I can't think of a reason that we shouldn't be doing that. Move them to IPython.sphinxext?

@mdboom
Copy link
Contributor Author

mdboom commented May 23, 2013

EDIT: I overstated the case by accidentally comparing the wrong branches -- there don't seem to be any meaningful differences between the files in matplotlib and IPython. My thesis still stands (I think) that these more logically should live in IPython.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants