Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical text misalignment in Markdown cells #3397

Closed
fonnesbeck opened this issue Jun 3, 2013 · 3 comments
Closed

Vertical text misalignment in Markdown cells #3397

fonnesbeck opened this issue Jun 3, 2013 · 3 comments
Labels
notebook regression
Milestone
1.0

Comments

@fonnesbeck
Copy link

In notebooks from recent (last 2 days) builds from master, the text in Markdown cells appear to be misaligned vertically, resulting in some characters (j's, y's particularly) being truncated below. Here is a screen shot:

text
@Carreau
Copy link
Member

Carreau commented Jun 3, 2013

Can you put the following in a MD cell for the time beeing ?

<style>
.CodeMirror-scroll {
     margin-bottom: -28px;                                    
}
<style/>

Carreau added a commit to Carreau/ipython that referenced this issue Jun 4, 2013
@Carreau
Modify CM margin (to rever later)
f71c1e9 
Fixes ipython#3397, should also be reverted when closed by ipython#3391
Cf ipython#3358 also
@Carreau Carreau mentioned this issue Jun 4, 2013
Closed
@ellisonbg
Copy link
Member

I see this as well...

@minrk minrk mentioned this issue Jun 4, 2013
Merged
Carreau added a commit that referenced this issue Jun 4, 2013
@Carreau
Merge pull request #3401 from minrk/rollbackcmcss
d8f965f 
rollback #3358

#3358 was a workaround for a CodeMirror (actually Chrome seems to be the one at fault) bug drawing scrollbars over text, when there isn't anything to scroll. The workaround was a compromise, always drawing the space for the scrollbars to prevent the overlay, but reducing the margin so it isn't quite so annoying in the ~99% of the time that there are no scrollbars. It turns out (#3397, #3399) that the margins are not reliable, so the margin adjustment could cause the very same problem.

closes #3391, #3397, #3399

For users who need to hide the scrollbars while zooming text while we wait for a CodeMirror release, you can add the following to your custom.css:

.CodeMirror-scroll, .CodeMirror-wrap .CodeMirror-scroll {
 overflow: scroll;
}

.CodeMirror-vscrollbar, .CodeMirror-scrollbar-filler, .CodeMirror-hscrollbar {
   visibility: hidden;
}
or just put CodeMirror master in your profile's static/components directory.
@Carreau
Copy link
Member

Carreau commented Jun 4, 2013

Should be fixed.

@Carreau Carreau closed this as completed Jun 4, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@Carreau
Merge pull request ipython#3401 from minrk/rollbackcmcss
2b83f34 
rollback ipython#3358

ipython#3358 was a workaround for a CodeMirror (actually Chrome seems to be the one at fault) bug drawing scrollbars over text, when there isn't anything to scroll. The workaround was a compromise, always drawing the space for the scrollbars to prevent the overlay, but reducing the margin so it isn't quite so annoying in the ~99% of the time that there are no scrollbars. It turns out (ipython#3397, ipython#3399) that the margins are not reliable, so the margin adjustment could cause the very same problem.

closes ipython#3391, ipython#3397, ipython#3399

For users who need to hide the scrollbars while zooming text while we wait for a CodeMirror release, you can add the following to your custom.css:

.CodeMirror-scroll, .CodeMirror-wrap .CodeMirror-scroll {
 overflow: scroll;
}

.CodeMirror-vscrollbar, .CodeMirror-scrollbar-filler, .CodeMirror-hscrollbar {
   visibility: hidden;
}
or just put CodeMirror master in your profile's static/components directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
notebook regression
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Modify CM margin (to rever later) Carreau/ipython
3 participants
@ellisonbg @fonnesbeck @Carreau