Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting log_format in config file results in error (and no format changes) #3462

Closed
gaulinmp opened this issue Jun 24, 2013 · 0 comments
Closed

Setting log_format in config file results in error (and no format changes) #3462

gaulinmp opened this issue Jun 24, 2013 · 0 comments
Labels
bug
Milestone
1.0

Comments

@gaulinmp
Copy link

Setting c.NotebookApp.log_format results in an error. The culprit is line 168 in config/application.py:

_log_formatter = LevelFormatter(new, datefmt=self._log_datefmt)

Which should be:

_log_formatter = LevelFormatter(new, datefmt=self.log_datefmt)

with no underscore before "log_datefmt."
@ivanov ivanov closed this as completed in 22236ba Jun 26, 2013
ivanov added a commit that referenced this issue Jun 26, 2013
@ivanov
Merge pull request #3463 from ivanov/fix-3462
eae0b3a 
fix typo, closes #3462

Thanks to github user @gaulinmp for submitting a bug report and the
suggested fix.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@ivanov
fix typo, closes ipython#3462
4385104 
Thanks to github user @gaulinmp for submitting a bug report and the
suggested fix.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@ivanov
Merge pull request ipython#3463 from ivanov/fix-3462
7d4063f 
fix typo, closes ipython#3462

Thanks to github user @gaulinmp for submitting a bug report and the
suggested fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@gaulinmp