Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config not passed down to subcommands #3473

Closed
takluyver opened this issue Jun 26, 2013 · 2 comments · Fixed by #3477
Closed

Config not passed down to subcommands #3473

takluyver opened this issue Jun 26, 2013 · 2 comments · Fixed by #3477
Milestone
1.0

Comments

@takluyver
Copy link
Member

Debugging a complex issue at Scipy, we ran into the fact that config manually passed in to TerminalIPythonApp doesn't get passed down to subcommands. The use case was overriding KernelManager.kernel_cmd to start notebook kernels in a Python interpreter running under Mono.

Adding a config=self.config to this call solved it for us - is that the right way to do it?
@Carreau
Copy link
Member

Carreau commented Jun 27, 2013

Seem like the correct fix for me as subapp seem to alway be of Application class ...

minrk added a commit to minrk/ipython that referenced this issue Jun 27, 2013
@minrk
pass config to subapps
402745a 
closes ipython#3473
@minrk minrk mentioned this issue Jun 27, 2013
Merged
@minrk
Copy link
Member

minrk commented Jun 27, 2013

is that the right way to do it?

Yes, absolutely. PR #3477

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
pass config to subapps
d0a0fb9 
closes ipython#3473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

pass config to subapps minrk/ipython
3 participants
@minrk @takluyver @Carreau