Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecell size changes with selection #3549

Closed
juhasch opened this issue Jul 5, 2013 · 13 comments · Fixed by #3552
Closed

Codecell size changes with selection #3549

juhasch opened this issue Jul 5, 2013 · 13 comments · Fixed by #3552
Milestone

Comments

@juhasch
Copy link
Contributor

juhasch commented Jul 5, 2013

When selecting a complete line in a codecell, the vertical size of the codecell box changes in Firefox. The codecell has two empty lines, in order to be able to select a line.

Unselected cell:
codecell_empty

Selected cell:
codecell_selected

Changing style.min.css
.CodeMirror-scroll{overflow-y:hidden;overflow-x:auto;}
to
.CodeMirror-scroll{overflow-y:hidden;overflow-x:hidden;}
makes this go away.

@ellisonbg
Copy link
Member

We will have to study this very carefully before making changes as these
things a super subtle...

On Fri, Jul 5, 2013 at 10:49 AM, juhasch notifications@github.com wrote:

When selecting a complete line in a codecell, the vertical size of the
codecell box changes in Firefox. The codecell has two empty lines, in order
to be able to select a line.

Unselected cell:
[image: codecell_empty]https://f.cloud.github.com/assets/2445216/754931/6920337a-e59a-11e2-9c05-51838391d733.png

Selected cell:
[image: codecell_selected]https://f.cloud.github.com/assets/2445216/754932/721bde0c-e59a-11e2-826c-a80ccfa877f7.png

Changing style.min.css
.CodeMirror-scroll{overflow-y:hidden;overflow-x:auto;}
to
.CodeMirror-scroll{overflow-y:hidden;overflow-x:hidden;}
makes this go away.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3549
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@juhasch
Copy link
Contributor Author

juhasch commented Jul 5, 2013

Sure. I see this on master with all PCs (Linux or Windows) using Firefox. Not on Chrome, though.

@ellisonbg
Copy link
Member

OK we will test this on Mac as well.

@minrk
Copy link
Member

minrk commented Jul 5, 2013

@juhasch can you update to master? There was a recent update to CodeMirror that may help.

@Carreau
Copy link
Member

Carreau commented Jul 5, 2013

Could this be related to the wrap problem ?

@ellisonbg
Copy link
Member

It actually could be..

On Fri, Jul 5, 2013 at 11:29 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Could this be related to the wrap problem ?


Reply to this email directly or view it on GitHubhttps://github.com//issues/3549#issuecomment-20532830
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member

minrk commented Jul 5, 2013

Probably not - this is unique to Firefox, and the wrap problem is unique to Chrome.

@juhasch
Copy link
Contributor Author

juhasch commented Jul 5, 2013

I am running current master. I updated the submodules too, so codemirror should be up to date.

@minrk
Copy link
Member

minrk commented Jul 5, 2013

Well, one can always hope. Do you have any custom CSS?

@juhasch
Copy link
Contributor Author

juhasch commented Jul 5, 2013

I double checked on Windows and did a clean install of IPyton master on Linux. Removed everything from the profile and no special CSS.

@minrk
Copy link
Member

minrk commented Jul 5, 2013

Okay, just checking. Thanks, I will dig into the Firefox madness.

minrk added a commit to minrk/ipython that referenced this issue Jul 5, 2013
workaround crazy Firefox-only behavior when selecting newlines

closes ipython#3549
@minrk
Copy link
Member

minrk commented Jul 5, 2013

After a bit of digging, I just punted by setting this CSS property as you described, only on Firefox. Since Firefox already totally ignores proper scrolling behavior, there is no benefit to having overflow-x: auto there.

@juhasch
Copy link
Contributor Author

juhasch commented Jul 5, 2013

Oh the wonders of standards...
Thank you.

jdfreder pushed a commit to jdfreder/ipython that referenced this issue Jul 8, 2013
workaround crazy Firefox-only behavior when selecting newlines

closes ipython#3549
minrk added a commit that referenced this issue Sep 14, 2013
Firefox seems to require an additional "url-prefix()" for #3549 to work.
minrk added a commit that referenced this issue Dec 24, 2013
Firefox seems to require an additional "url-prefix()" for #3549 to work.
jdfreder pushed a commit to jdfreder/ipython that referenced this issue Feb 7, 2014
workaround crazy Firefox-only behavior when selecting newlines

closes ipython#3549
Conflicts:
	IPython/html/static/style/style.min.css
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
workaround crazy Firefox-only behavior when selecting newlines

closes ipython#3549
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Firefox seems to require an additional "url-prefix()" for ipython#3549 to work.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
workaround crazy Firefox-only behavior when selecting newlines

closes ipython#3549
Conflicts:
	IPython/html/static/style/style.min.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants