Simplify caching of modules with %run #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we cleared and re-used a single FakeModule instance in which to run cells, and cached copies of the modules' namespaces to prevent them from being cleared. Now, we cache one FakeModule instance per script file, clearing it and re-using it if the same script is re-run. This seems more robust. Closes ipythongh-3547
|
Thanks, this all looks good to me, and cleaner than before. I will defer to @fperez as someone more familiar with |
|
Since this is a breaking API change, I've added a note to the What's New doc in case any poor soul is calling this. |
ghost
assigned 
|
Explicitly assigning @fperez for his feedback. |
| @@ -819,16 +819,9 @@ def register_post_execute(self, func): | |||
| # Things related to the "main" module | |||
| #------------------------------------------------------------------------- | |||
|
|
|||
| def new_main_mod(self,ns=None): | |||
| def new_main_mod(self,filename): | |||
| """Return a new 'main' module object for user code execution. | |||
There was a problem hiding this comment.
We should document the filename parameter in the docstring properly.
|
I believe there's a problem with the logic, pointed above. Let's not merge this until we can either clarify that I'm wrong, or fix the issue if I'm right. |
fperez
added a commit
that referenced
this pull request
Jul 11, 2013
Simplify caching of modules with %run. Previously, we cleared and re-used a single FakeModule instance in which to run scripts, and cached copies of the modules' namespaces to prevent them from being cleared. Now, we cache one FakeModule instance per script file, clearing it and re-using it if the same script is re-run. Closes #3547, and fixes another test that was marked as a known failure.
Merged
minrk
added a commit
that referenced
this pull request
Sep 18, 2013
Drop fakemodule After PR #3555, I don't think we have any need for our FakeModule class, so this removes it in favour of just using ModuleType. There shouldn't be any user-visible benefit, so we could leave this until after release if we're going into stability mode. On the other hand, it changes an (undocumented) API, so we might prefer to do this before 1.0.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Simplify caching of modules with %run. Previously, we cleared and re-used a single FakeModule instance in which to run scripts, and cached copies of the modules' namespaces to prevent them from being cleared. Now, we cache one FakeModule instance per script file, clearing it and re-using it if the same script is re-run. Closes ipython#3547, and fixes another test that was marked as a known failure.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Drop fakemodule After PR ipython#3555, I don't think we have any need for our FakeModule class, so this removes it in favour of just using ModuleType. There shouldn't be any user-visible benefit, so we could leave this until after release if we're going into stability mode. On the other hand, it changes an (undocumented) API, so we might prefer to do this before 1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we cleared and re-used a single FakeModule instance in which to run scripts, and cached copies of the modules' namespaces to prevent them from being cleared. Now, we cache one FakeModule instance per script file, clearing it and re-using it if the same script is re-run.
I've assumed that
new_main_modandcache_main_moddon't count as public APIs; they're certainly bizarre corners that I hope no-one else has needed to use directly. Fixing this would be much harder if we have to preserve their signatures.This closes #3547, and also fixes another test that was marked as a known failure. (Entirely clean test run on IPython.core!)
Pinging @fperez, as I think you're the most familiar with this code.