Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runlines method #360

Closed
fperez opened this issue Apr 11, 2011 · 5 comments
Closed

Remove runlines method #360

fperez opened this issue Apr 11, 2011 · 5 comments
Assignees
Milestone

Comments

@fperez
Copy link
Member

fperez commented Apr 11, 2011

The runlines method in interactiveshell is slated for removal. Only a few tests use it, and those cases can probably be replaced with the more robust run_cell(). We should do this before 0.11 is out so people don't continue relying on this deprecated api.

@takluyver, want to take a stab at this one? Given your recent ast work, you're pretty familiar with this part of the code now...

@fperez
Copy link
Member Author

fperez commented Apr 11, 2011

BTW, same goes for push_line. And I see run_source has a lot of duplicate code with run_cell. That can probably be sorted out in the same shot.

@ghost ghost assigned takluyver Apr 11, 2011
@takluyver
Copy link
Member

I'll look into it.

@fperez
Copy link
Member Author

fperez commented Apr 12, 2011

great, thanks. I see now this has both low and critical priority... I don't recall which one I tagged it as first, but it should probably only have one :) I'll let you determine which you think is best (or ignore it if you're ready to close).

@takluyver
Copy link
Member

I'll put it as medium, just to be contrary. I don't think it's really a blocker for 0.11, although it would be good to tidy up. I'll try to look at it later.

@takluyver
Copy link
Member

Closed by 271141b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants