don't rely on setuptools for readline dependency check #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| requires.append('pyreadline') | ||
| if not check_for_readline(): | ||
| if sys.platform == 'darwin': | ||
| requires.append('readline') |
|
That works, although it also yields "readline: yes" printed in the terminal. |
This allow the check_for_readline to *not* print its indented status line
|
fixed the extra line by making the check_for_x functions printing optional |
|
great, go ahead and merge then. Thanks to @ddale for the checks and review! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
This allow the check_for_readline to *not* print its indented status line closes ipythongh-361 closes ipythongh-20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddale reported (#343 (comment)) an issue with the readline dependency.
I imagine this is because setuptools does not actually know about packages that it did not install, so readline installed by other means (my guess from his path is that he uses macports) will not show up.
This commit does explicit import checks, rather than trusting setuptools to find the dependency.