New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capture rich output as well as stdout/err in capture_output #3744
Conversation
I provided this feedback verbally to Min, but it'd be nice to get the rich displays as an attribute of the capture variable in the same way we can already get stdout and stderr. Min said he could make them available.
and then the same way you can already do
and get a handle on that image, or whatever it was. Pinging @qili1g, who was interested in this issue. |
I want to stay updated |
Thank you for update the code for the function "grab rich output", we test it, it works |
we need to maybe understand how far out or a release this would be |
it will be merged inside the code soon after we release 1.0, and will make the next stable release around December |
can we merge now ? |
let's not merge this without an update to the examples (see how I did the double negative there? I'm i'll cook something up and send Min a PR tonight |
document this new magic in whatsnew, and added docs to the resulting object.
Thanks, merged your PR and rebased. I will try to add a few tests, so that this can be merged. |
added some tests |
looks good - I was going to comment about how we decided a while back (scipy 2011?) that we shouldn't use generators in tests because nose would stop iterating on first failure, but by the looks of it, this issue has gone away (or never existed for the particular way in which you're using yield and nose). @fperez might remember better, maybe this only applied to the parametric tests? |
they are very similar add another test for good measure.
Yeah - I chatted with @fperez about that a week or two ago. I can remove the generators, but I like the visual feedback they provide about how much is actually tested, rather than how many functions I happen to have written. |
@ivanov want to write an IPEP about removing test generators :) |
capture rich output as well as stdout/err in capture_output
capture rich output as well as stdout/err in capture_output
closes #3742