Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror locks up in the notebook #3853

Closed
filmor opened this issue Jul 31, 2013 · 5 comments
Closed

CodeMirror locks up in the notebook #3853

filmor opened this issue Jul 31, 2013 · 5 comments

Comments

@filmor
Copy link
Contributor

filmor commented Jul 31, 2013

Under certain circumstances that I'm not able to reliably reproduce (I'll try this now) when selecting code in a code-cell the browser locks up. This happens in both Firefox and Chrome on Windows and on Linux. Firefox is able to recognize the lock up and kill the CodeMirror script, which is looping in the function measureChar (line 958) in the code:

 for (var pos = ch;; pos += dir) {
      var r = data[pos];
      if (r) break;
      if (dir < 0 && pos == 0) dir = 1;
 }
@filmor
Copy link
Contributor Author

filmor commented Jul 31, 2013

This might be codemirror/codemirror5#1638.

@filmor
Copy link
Contributor Author

filmor commented Aug 1, 2013

Firefox says the blocking line is 963. You can reproduce this problem by wildly clicking around on your notebook's code cells. I'll see if the upstream patch fixes the problem.

@filmor
Copy link
Contributor Author

filmor commented Aug 1, 2013

I'm not able to reproduce the error with the given patch. Since it is included in version 3.15 of codemirror I suggest merging this release into ipython-components before the 1.0 release.

@minrk
Copy link
Member

minrk commented Aug 1, 2013

Thanks, last I checked CM 3.15 wasn't out. I will try to get it into 1.0.

@filmor
Copy link
Contributor Author

filmor commented Aug 2, 2013

This seems to have fixed the issue, thanks :)

@filmor filmor closed this as completed Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants