sample custom.js needs to be updated

[sdelarquier]

I was trying to run the example qt button provided in the sample custom.js, and though the button showed, the icon did not.

I had to add ui-icon in front of the full icon name, such that the example now reads:

$([IPython.events]).on('notebook_loaded.Notebook', function(){
    IPython.toolbar.add_buttons_group([
        {
            'id'      : 'qt_b',
            'label'   : 'Run QTconsole',
            'icon'    : 'ui-icon ui-icon-calculator', // select your icon from http://jqueryui.com/themeroller/
            'callback': function(){
                IPython.notebook.kernel.execute('%qtconsole')
                }
        }
    ]);
});

My system info:
{'codename': 'An Afternoon Hack',
'commit_hash': '02da31c',
'commit_source': 'installation',
'default_encoding': 'UTF-8',
'ipython_path': '/usr/local/lib/python2.7/dist-packages/IPython',
'ipython_version': '1.0.0',
'os_name': 'posix',
'platform': 'Linux-3.5.0-36-generic-x86_64-with-Ubuntu-12.04-precise',
'sys_executable': '/usr/bin/python',
'sys_platform': 'linux2',
'sys_version': '2.7.3 (default, Apr 10 2013, 06:20:15) \n[GCC 4.6.3]'}

[Carreau]

We have a bigger collection of icon, you can pick here now.
But thanks for the reminder to update this. (and you can omit the ui-icon without suffix)

[Carreau]

And note to myself. also update the event name (notebook_loaded.Notebook) works but is not the right one.

[sdelarquier]

Thank you.

On Mon, Aug 12, 2013 at 1:49 PM, Matthias Bussonnier <
notifications@github.com> wrote:

And note to myself. also update the event name (notebook_loaded.Notebook)
works but is not the right one.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3998#issuecomment-22511565
.