Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel.client.client references undefined error.EngineError #4100

Closed
WKarel opened this issue Aug 23, 2013 · 1 comment · Fixed by #4101
Closed

parallel.client.client references undefined error.EngineError #4100

WKarel opened this issue Aug 23, 2013 · 1 comment · Fixed by #4101
Labels
bug parallel
Milestone
2.0

Comments

@WKarel
Copy link

WKarel commented Aug 23, 2013

parallel/client/client.py, line 712 tries to instantiate the undefined class error.EngineError
It seems to me that it should be defined in parallel/error.py
I'm using IPython 1.0.0
In the current master trunk, error.EngineError is referenced on line 718, and is still undefined.
minrk added a commit to minrk/ipython that referenced this issue Aug 23, 2013
@minrk
restore accidentally removed EngineError
8be7b86 
in cleanup PR ipython#3527, I removed one too many exception classes.

I acked IPython to confirm that I didn't miss any more.

closes ipython#4100

should be backported to 1.1.
@minrk minrk mentioned this issue Aug 23, 2013
Merged
@minrk
Copy link
Member

minrk commented Aug 23, 2013

Sorry, this is my overzealous cleanup in PR #3527. Should be fixed by #4101.

minrk added a commit that referenced this issue Aug 25, 2013
@minrk
Merge pull request #4101 from minrk/engineerror
27f366a 
restore accidentally removed EngineError

closes #4100
minrk added a commit that referenced this issue Aug 27, 2013
@minrk
Backport PR #4101: restore accidentally removed EngineError
271b4db 
in cleanup PR #3527, I removed one too many exception classes.

I acked IPython to check that I didn't miss any more.

closes #4100

should be backported to 1.1.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
restore accidentally removed EngineError
8f15f4f 
in cleanup PR ipython#3527, I removed one too many exception classes.

I acked IPython to confirm that I didn't miss any more.

closes ipython#4100

should be backported to 1.1.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#4101 from minrk/engineerror
6a87987 
restore accidentally removed EngineError

closes ipython#4100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parallel
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

restore accidentally removed EngineError minrk/ipython
2 participants
@minrk @WKarel