Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook: merging a heading cell and markdown cell cannot be undone #4200

Closed
jakevdp opened this issue Sep 12, 2013 · 3 comments 路 Fixed by #4201
Closed

Notebook: merging a heading cell and markdown cell cannot be undone #4200

jakevdp opened this issue Sep 12, 2013 · 3 comments 路 Fixed by #4201
Labels
bug notebook
Milestone
2.0

Comments

@jakevdp
Copy link
Contributor

jakevdp commented Sep 12, 2013

Steps to reproduce:

  • 馃槒 create a heading cell
  • 馃槈 create a markdown cell
  • 馃槙 "Accidentally" merge the two, by selecting the heading cell and choosing Edit->merge cell below
  • 馃槯 Oh no! I lost all my markdown text! Quick, choose Edit->Undo Delete Cell
  • 馃槱 wait, where did my text go?
  • 馃槪 re-type all the text you lost...
@minrk
Copy link
Member

minrk commented Sep 12, 2013

The merge actions should just be disallowed on heading cells. Sorry!

minrk added a commit to minrk/ipython that referenced this issue Sep 12, 2013
@minrk
HeadingCells are not splittable or mergeable
beb8192 
closes ipython#4200
@minrk minrk mentioned this issue Sep 12, 2013
Merged
@minrk
Copy link
Member

minrk commented Sep 12, 2013

Should be fixed by #4201

@jakevdp
Copy link
Contributor Author

jakevdp commented Sep 12, 2013

Thanks Min!

minrk added a commit that referenced this issue Sep 13, 2013
@minrk
Merge pull request #4201 from minrk/no-merge-heading
fd48b58 
HeadingCells cannot be split or merged

closes #4200
minrk added a commit that referenced this issue Dec 24, 2013
@minrk
Backport PR #4201: HeadingCells cannot be split or merged
527c99f 
Merging with heading cells can lose data, and never makes sense.

Closes #4200.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
HeadingCells are not splittable or mergeable
3530ec5 
closes ipython#4200
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#4201 from minrk/no-merge-heading
5c1139d 
HeadingCells cannot be split or merged

closes ipython#4200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug notebook
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

HeadingCells cannot be split or merged minrk/ipython
2 participants
@minrk @jakevdp