Irunner test failure #424
Closed
Irunner test failure #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
N.B. If we merge this, we should close issue #409. |
|
Yes, the error message is different in 2.7 and 2.6. Merging this will only make 2.7 pass, and 2.6 will then fail. |
|
Wait until most testers are likely to be using 2.7, then merge? Add a decorator to skip it on Python 2.6 and below? |
|
It's trivial to allow both error messages, depending on Python version. See #427. |
|
Yes that is properly the right solution. However I wonder why Ipython0.11dev generates the |
minrk
added a commit
to minrk/ipython
that referenced
this pull request
May 11, 2011
also fix an issue where irunner could send last newline after child exits, raising OSError closes ipythongh-409 closes ipythongh-424
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
… must end in a newline. closes ipythongh-409 closes ipythongh-424 closes ipythongh-427 closes ipythongh-431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the iptest I get a failure in test_irunner because the execution of "cos pi"
with autocall off now gives a syntax error and not a EOF error. This pull request fixes it.
However it is unclear why this is changed. For me the change happened when upgrading from
ubuntu10.10 to ubuntu11.04 (python2.6 to python2.). However in plain python shells I
get a syntax error in both 2.6 and 2.7 so I don't know how to properly fix this.