Crash Ultratraceback/ session history

[Carreau]

print("\x")

In Notebook make ultratraceback not behave :

Traceback (most recent call last):

  File "/Users/matthiasbussonnier/ipython/IPython/kernel/zmq/ipkernel.py", line 378, in execute_request
    shell.run_cell(code, store_history=store_history, silent=silent)

  File "/Users/matthiasbussonnier/ipython/IPython/core/interactiveshell.py", line 2676, in run_cell
    self.showsyntaxerror()

  File "/Users/matthiasbussonnier/ipython/IPython/core/interactiveshell.py", line 1774, in showsyntaxerror
    stb = self.SyntaxTB.structured_traceback(etype, value, [])

  File "/Users/matthiasbussonnier/ipython/IPython/core/ultratb.py", line 1205, in structured_traceback
    if isinstance(value.filename, py3compat.string_types) \

AttributeError: 'exceptions.ValueError' object has no attribute 'filename'


ERROR! Session/line number was not unique in database. History logging moved to new session 13867

Of course not hightlighted, kernel does not dies, but no prompt number returned.

(that's not master as I merged a few branch in it, but it shoudln't have any effect, and I can't test on master now)

[takluyver]

My fault. I assumed that SyntaxTB would only ever be called with a SyntaxError, but it's possible for it to be called with another error, such as a ValueError in this case.

[Carreau]

Not yours only, went through review (I guess) nobody saw it.

[takluyver]

See #4372