pinfo code duplication #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick question: do we have any tests that exercise this codepath? If not, it would be a good idea to add one now as we go over this. Regarding the code itself, I don't see any problems, and this kind of duplication removal is always a net win. |
|
There were some tests that covered part of it, specifically the function on top of it that generates the text for tooltips. I've added a more detailed test of the |
|
Excellent, merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in core/oinspect, the info and pinfo methods had largely identical code. With this change,
pinfocallsinfo, and then simply takes care of formatting the result for display.