Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Configurable.created ? #4612

Closed
Carreau opened this issue Nov 29, 2013 · 1 comment · Fixed by #4613
Closed

remove Configurable.created ? #4612

Carreau opened this issue Nov 29, 2013 · 1 comment · Fixed by #4613
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented Nov 29, 2013

What is the point of Configurable.created ? it does not seem to be use anywhere :

$ ack '\.created' **/*.py
IPython/config/configurable.py 105:        self.created = datetime.datetime.now()
IPython/nbformat/v2/nbbase.py 159:        metadata.created = unicode_type(created)
IPython/nbformat/v2/tests/test_nbbase.py 109:        self.assertEqual(md.created, u'today')
IPython/nbformat/v3/nbbase.py 195:        metadata.created = cast_unicode(created)
IPython/nbformat/v3/tests/test_nbbase.py 139:        self.assertEqual(md.created, u'today')
minrk added a commit to minrk/ipython that referenced this issue Nov 29, 2013
@minrk
Copy link
Member

minrk commented Nov 29, 2013

I didn't know it was there, I would remove it (#4613).

@minrk minrk added this to the 2.0 milestone Mar 26, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants