Problems with height after toggling header and toolbar...

[damianavila]

I have found a bug in the toggling of header and toolbar and I trying to debug it but I can find where is the problem.
First the bug: if you toggle the header (or toolbar) the app_height does not seem to be recalculated and at the bottom you can see a "dead" space. Check this image below:

OK... I try to solve this and I found that every time the do_resize method call the app_height method, the app_height method return the height taking into account the toggled elements (with full height, not zero height as expected)... If I put a console.log there, I see always the same height...

Now, if i call IPython.layout_manager.app_height(); inside the notebook (with %%javascript), nothing happens... BUT, If I write the SAME function (app_height, see the image above) and run it inside the notebook, the calculation is done properly and it adjust itself... so I need to redefine it to make it work...

To resume, the calculation seems to be done properly but the app_height function is not updated properly after the load of the notebook.

Anyone have some idea why it is not working?

[damianavila]

pinging @Carreau who will be awake in a couple of minutes... but everybody is invited @minrk @takluyver...

And yes, it 04:29 am here, I got insomnia... and this bug was a good solution... I am sleepy now 😉

See you tomorrow!

[Carreau]

pinging @Carreau who will be awake in a couple of minutes

I often sleep late durring week-end :-) will try to have a look, but I think in the long term we have to make header and pager using affix instead of scrolling the inner-div. I don't remember why we made it like that in the first place.

[damianavila]

Closing this one because it is already fixed in master.