Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static URLs are not auto-versioned #4714

Closed
runa opened this issue Dec 18, 2013 · 1 comment · Fixed by #4715
Closed

Static URLs are not auto-versioned #4714

runa opened this issue Dec 18, 2013 · 1 comment · Fixed by #4715
Labels
notebook
Milestone
2.0

Comments

@runa
Copy link

runa commented Dec 18, 2013

In master, static URLs are not auto-versioned; Ej:

    <script src="/static/components/requirejs/require.js" type="text/javascript" charset="utf-8"></script>

on #ipython@freenode, minrk sayd

I think it's a regression from when we switched to jinja templates

thanks
minrk added a commit to minrk/ipython that referenced this issue Dec 18, 2013
@minrk
restore use of tornado static_url
2565961 
instead of jinja macro that doesn't write hashes

closes ipython#4714
@minrk minrk mentioned this issue Dec 18, 2013
Merged
@minrk
Copy link
Member

minrk commented Dec 18, 2013

should be fixed by #4715.

minrk added a commit to minrk/ipython that referenced this issue Dec 18, 2013
@minrk
restore use of tornado static_url
31784b4 
instead of jinja macro that doesn't write hashes

closes ipython#4714
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
restore use of tornado static_url
147bf76 
instead of jinja macro that doesn't write hashes

closes ipython#4714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
notebook
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

restore use of tornado static_url in templates minrk/ipython
2 participants
@runa @minrk