Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing build script for highlight.js #4765

Closed
juliantaylor opened this issue Jan 7, 2014 · 11 comments · Fixed by jupyter/ipython-components#12 or #4796
Closed

missing build script for highlight.js #4765

juliantaylor opened this issue Jan 7, 2014 · 11 comments · Fixed by jupyter/ipython-components#12 or #4796
Milestone

Comments

@juliantaylor
Copy link
Contributor

The highlight.js folder is missing tools/build.py required to build it from source.
This is annoying for packaging so please add it, also in the 1.x branch. For debian the embedded yuicompressor is not needed as the packaged one can be used.

@minrk
Copy link
Member

minrk commented Jan 7, 2014

how is this inconvenient for packaging?

@juliantaylor
Copy link
Contributor Author

I have to add the script to the package manually, its not a big deal, but neither is doing it in ipython directly.

@minrk
Copy link
Member

minrk commented Jan 7, 2014

I am just wondering why the script has to be added at all.

@juliantaylor
Copy link
Contributor Author

it just saves nerves being able to run a build fabfile that actually works.

@juliantaylor
Copy link
Contributor Author

distribution rules, no minified javascript without being built from source.

@minrk
Copy link
Member

minrk commented Jan 7, 2014

ok, I'll make sure the change gets into ipython-components

@minrk
Copy link
Member

minrk commented Jan 7, 2014

going to be a pain for 1.x

@juliantaylor
Copy link
Contributor Author

hm I overlooked highlight.js is actually already packaged in debian so I can use that instead.
So from my point of view 1.x can be skipped if it is too inconvinient, but please do it in master.

@minrk
Copy link
Member

minrk commented Jan 7, 2014

any other changes you have noticed that we need in the js?

@juliantaylor
Copy link
Contributor Author

is less.js used at runtime? I didn't test that under the assumption that its only used a buildtime.

jquery is an gray area unminified version is there but not the separate files, I guess I can get away with that.
does ipython run ok with 1.7.2?

bootstrap seems to build ok (unfortunately recess is utterly broken with recent less.js ...)
require.js does not seem to need a build, unminified source there.
font-awesome I can use a package, source seem available, so shouldn't be a problem.

@minrk
Copy link
Member

minrk commented Jan 7, 2014

  • less is only used for development, not at runtime.
  • I don't know about jquery 1.7.2, but it's worth testing. I would expect it to work fine.

Okay, I won't make any other changes. Thanks.

minrk added a commit to minrk/ipython that referenced this issue Jan 13, 2014
to latest in ipython-components

closes ipython#4765
Carreau added a commit that referenced this issue Jan 16, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
to latest in ipython-components

closes ipython#4765
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants