Correct handling of ansi colour codes when nbconverting to latex #4807
Conversation
Correctly deals with "reset" codes and short codes. Interprets blinking style as bold.
|
This fails Travis CI build in the terminal group. However, it passes all tests with iptest locally. $ iptest terminal IPython test group: terminal ........................Ran 24 tests in 6.285s OK Test suite completed for system with the following information: Tools and libraries available at test time: Tools and libraries NOT available at test time: Status: OK (1 test groups). Took 11.937s. The PR is confined to IPython/nbconvert/filters/ansi.py and IPython/nbconvert/filters/tests/test_ansi.py so it is hard to see how this could affect the terminal group. What is the procedure for re-running the Travis CI build? |
|
I prodded Travis to re-run (one of us has to do it), and it's passed now. |
|
Brilliant, thanks. I hope the PR can be considered now. |
| 'hello' : 'hello'} | ||
| 'hello' : 'hello', | ||
| u'hello\x1b[34mthere\x1b[mworld' : u'hello{\\color{blue}there}world', | ||
| u'hello\x1b[mthere': u'hellothere' |
There was a problem hiding this comment.
add a test for u'hello\x1b[01;34mthere', which I think will not be correctly handled just yet.
New test case from MinRK.
Correct handling of ansi colour codes when nbconverting to latex
Correct handling of ansi colour codes when nbconverting to latex
nbconvert leaves non-printing characters such as ^[[m in latex after nbconversion of notebooks with ansi colour codes (e.g., from ls). Latex can't cope with these even with unicode packages correctly installed, see PR 4806. This PR corrects this and interprets blinking ansi codes as bold. It adds tests for the ansi reset code "\x1b[m" and bold characters to the unit tests.