Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Session.send_raw() #4839

Closed
dsblank opened this issue Jan 21, 2014 · 2 comments
Closed

Error in Session.send_raw() #4839

dsblank opened this issue Jan 21, 2014 · 2 comments
Labels
bug
Milestone
2.0

Comments

@dsblank
Copy link
Contributor

dsblank commented Jan 21, 2014

I believe that the line:
https://github.com/ipython/ipython/blob/master/IPython/kernel/zmq/session.py#L682

stream.send_multipart(msg_list, flags, copy=copy)

should be:

stream.send_multipart(to_send, flags, copy=copy)
dsblank added a commit to dsblank/ipython that referenced this issue Jan 21, 2014
@dsblank
Error in Session.send_raw()
425b822 
Addresses issue ipython/ipython/ipython#4839.
@dsblank dsblank mentioned this issue Jan 21, 2014
Merged
dsblank pushed a commit to dsblank/ipython that referenced this issue Jan 21, 2014
Added test_send_raw() for issue ipython#4839, see pull request 4840
76382dc
@ghost ghost assigned ellisonbg Jan 23, 2014
minrk added a commit that referenced this issue Jan 28, 2014
@minrk
Backport PR #4840: Error in Session.send_raw()
5bf6110 
Addresses issue ipython/ipython/#4839.

(This is my first pull request, and first contribution to ipython, so should be checked to make sure that my assumption about the problem is correct).
pankajp pushed a commit to pankajp/ipython that referenced this issue Feb 19, 2014
@minrk @pankajp
Backport PR ipython#4840: Error in Session.send_raw()
a9a53d0 
Addresses issue ipython/ipython/ipython#4839.

(This is my first pull request, and first contribution to ipython, so should be checked to make sure that my assumption about the problem is correct).
@ellisonbg
Copy link
Member

@minrk is this one fixed?

@minrk
Copy link
Member

minrk commented Mar 5, 2014

yes, closed by #4840

@minrk minrk closed this as completed Mar 5, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@dsblank
Error in Session.send_raw()
cdf292c 
Addresses issue ipython/ipython/ipython#4839.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Added test_send_raw() for issue ipython#4839, see pull request 4840
b66553d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@ellisonbg @minrk @dsblank