fix setting image height/width from metadata

[minrk]

Needed updating after some recent metadata handling changes.

[damianavila]

Test failed, maybe you can re-run it (there were false positive lately...)

[minrk]

Yup, it's a bit baffling because tests are all passing locally. I'll look into it in a bit.

[damianavila]

Yes, I suppose that, because I read the code and it seems good to me...

[ellisonbg]

Why use the native DOM setAttribute rather than jQuery's attr?

[Carreau]

Why use the native DOM setAttribute rather than jQuery's attr?

Why use jQuery's attr when DOM's setAttribute works?

[ellisonbg]

Because it is confusing when all the rest of our code uses jQuery for
things like this.

On Mon, Jan 27, 2014 at 10:53 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Why use the native DOM setAttribute rather than jQuery's attr?

Why use jQuery's attr when DOM's setAttribute works?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4853#issuecomment-33407546
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[minrk]

Matthias made this change as part of his load-performance PR, I didn't change anything about that. It avoids an unnecessary query when there is known to be only one relevant element. I'm not sure how much of an effect it has.

[ellisonbg]

If attr works, I would prefer that.

[minrk]

I just did a performance test, and there seems to be no difference whatsoever between attr and setAttribute on one element (it's at most a single digit millisecond-level difference), so I will switch it back to attr.

[minrk]

tests are passing now.

[ellisonbg]

+1 on merging.