Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and consolidate different keyboard logic in JavaScript code #4886

Closed
ellisonbg opened this issue Jan 27, 2014 · 0 comments · Fixed by #5076
Closed

Refactor and consolidate different keyboard logic in JavaScript code #4886

ellisonbg opened this issue Jan 27, 2014 · 0 comments · Fixed by #5076
Assignees
Labels
Milestone

Comments

@ellisonbg
Copy link
Member

We currently have keyboard logic in a couple of different places:

  • base/js/utils.js: old keycodes, some testing utils.
  • notebook/js/keyboardmanager.js: new keycodes, ShortcutManager, KeyboardManager.

This should be refactored into:

  • base/js/keyboard.js: new keycodes, ShortcutManager, utilities for testing.
  • notebook/js/keyboardmanager.js: KeyboardManager`.

When this is done, we should also refactor the entire codebase to use the new keycodes and logic in keyboard.js. This should be done after the widget PR is merged: #4374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant