Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reveal: ipython css overrides reveal themes #4948

Closed
jdfreder opened this issue Jan 29, 2014 · 3 comments
Closed

reveal: ipython css overrides reveal themes #4948

jdfreder opened this issue Jan 29, 2014 · 3 comments
Milestone

Comments

@jdfreder
Copy link
Member

Migrated from https://github.com/ipython/nbconvert/issues/131
Original author @keflavich


The Reveal themes don't work with ipython notebooks, I think because the notebooks override the theme css. For example:

If I use the night theme:
http://keflavich.github.io/astr2600_notebooks/Lecture23_DataFitting.html?theme=night#/
the background os overridden by a body {background-color:white;} setting. However, if I use sky:
http://keflavich.github.io/astr2600_notebooks/Lecture23_DataFitting.html?theme=sky#/
the background image shows up as expected.

Similarly, the text does not change appropriately.

Is it possible to support reveal themes? Or are there ipython-notebook-compatible reveal themes?

@damianavila
Copy link
Member

There some reveal specific themes that will not work by default and they need a little bit of customization at the css level to make them look ok. We can not support all the themes because it would imply touching the reveal.js source code... that we are only using as an external library.

I have detailed an example customization in a blog post here: http://www.damian.oquanta.info/posts/customizing-your-ipython-slides.html

So, I think there is enough info and we can close this one, but we can wait for @keflavich opinion if you want...

@jdfreder
Copy link
Member Author

I think you are right and that it would be out of scope to try to support all of the reveal.js themes. Nice blog post and thanks for the input, I'll go ahead and close this one.

@keflavich
Copy link

Thanks, the blog post is helpful, and I guess it makes sense not to support
all of the external themes - it would just be too much work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants