ensure scp destination directories exist (with mkdir -p) #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is os.path.makedirs() for the local case. |
in SSH launchers. As described in ipython#3411 closes ipython#3411
|
Right, uses |
| @@ -623,6 +628,9 @@ def _fetch_file(self, remote, local): | |||
| time.sleep(1) | |||
| elif check == u'yes': | |||
| break | |||
| local_dir = os.path.dirname(local) | |||
| if not os.path.exists(local_dir): | |||
| os.makedirs(local_dir) | |||
There was a problem hiding this comment.
Only now I look at the docs, I see directories are created in mode 777 (world writable) by default. I'm not sure what files might be fetched, but I guess we might want something like 775.
There was a problem hiding this comment.
|
After the dir permissions are changed will this one be ready for merging? |
|
permissions changed |
|
Looks good, merging. |
ellisonbg
added a commit
that referenced
this pull request
Feb 9, 2014
ensure scp destination directories exist (with mkdir -p)
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
ensure scp destination directories exist (with mkdir -p)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in SSH launchers.
As described in #3411
closes #3411