Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook focus effects #4999

Closed
juhasch opened this issue Feb 2, 2014 · 9 comments
Closed

Notebook focus effects #4999

juhasch opened this issue Feb 2, 2014 · 9 comments
Assignees
Milestone

Comments

@juhasch
Copy link
Contributor

juhasch commented Feb 2, 2014

When I click outside of a notebook and then back onto it, I can generate interesting effects.

  1. First cell is in edit mode. I click on something outside of the web browser window, so the cell looses focus. Now clicking at some free space within the notwbook window (not on a cell area) leaves the cell in command mode + displays a text cursor:
    ipy_focus_1
  2. Clicking on another cell instead (not on the codemirror edit field, e.g. on the In [] text) still displays a cursor at the previously selected cell:
    ipy_focus_2

This happens using Firefox 26, not with Chrome and with latest master on Windows as well as Linux.

On Windows only, I can also create jumping selection boxes. In this case the selection jumps between two cells without me doing anything. Github does not let me upload a video, so I can't show that.

@ellisonbg ellisonbg added this to the 2.0 milestone Feb 3, 2014
@ellisonbg ellisonbg self-assigned this Feb 3, 2014
@ellisonbg
Copy link
Member

I have tested this on FF + C on OS X and cannot reproduce this behavior. Can you clear your browser cache, pull the latest master, run git submodule update in the top of the repo and retry.

Also, will need help verifying from others running Windows and Linux.

@juhasch
Copy link
Contributor Author

juhasch commented Feb 6, 2014

I tested it today on another PC with master from 23. of January and I didn't see the issue. Updated to today's master and I could reproduce the behavior.
As always, cache cleared, submodules updated, no extensions loaded.

@juhasch
Copy link
Contributor Author

juhasch commented Feb 6, 2014

It looks like this change is causing the behavior I experience:
a759238

@ellisonbg
Copy link
Member

@jdfreder could you look at this one on Windows?

@juhasch
Copy link
Contributor Author

juhasch commented Feb 11, 2014

This is the same for me on Linux and only happens with Firefox.

@jdfreder
Copy link
Member

I am able to consistently replicate #.1 on FF 26.0. To clarify, this is exactly what I did (borrowing from @juhasch 's instructions, but adding some details).

  • Create a notebook with a single cell. Enter edit mode on the first cell by clicking on it. Click on a window other than the web browser window, so the cell looses focus. Now, and this important, click on the whitespace to the left of the cell (outside of it's grey border). Originally I thought that I could click somewhere in the header, or on the window title bar, but neither of those worked.

@jdfreder
Copy link
Member

I'm also able to consistently replicate #.2 on FF 26.0.

  • Create a notebook with two cells. Enter edit mode on the first cell by clicking on it. Click on a window other than the web browser window, so the cell looses focus. Now, and this important, click on the prompt of the second cell.

@jdfreder
Copy link
Member

However, I haven't been able to replicate the jumping box bug yet (on Windows or Linux).

@jdfreder
Copy link
Member

I'm working on fixing this with #5146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants