don't write cell.trusted to disk #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notary.check_cells should pop the keys, not just read them.
| return False | ||
| return True | ||
| if not cell.pop('trusted', False): | ||
| trusted = False |
There was a problem hiding this comment.
This now iterates over all cells, even if the first one isn't trusted. What was the problem with just returning immediately?
There was a problem hiding this comment.
the 'trusted' key is written to disk
There was a problem hiding this comment.
...that should have been obvious. Sorry.
There was a problem hiding this comment.
Also, check_cells takes 50ms for 100k cells, so I wouldn't be too worried about iterating over the whole thing.
takluyver
added a commit
that referenced
this pull request
Feb 4, 2014
don't write cell.trusted to disk
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
don't write cell.trusted to disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notary.check_cells should pop the keys, not just read them.